Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with CDAT/cdat#1163. There are a number of issues with modified clicks in Qt– for one, it reads ctrl + left on a mac as a right click. Presumably to work around this, they map the control modifier to the command button, and the meta modifier to the control button. I originally changed it to use the meta button, but that led me to discover the issue with Qt interpreting ctrl+left as a right click.
Another issue that was happening is that VTK doesn't know how to interpret the Qt Keyboard Modifier objects– it would wind up setting the interactor's ControlKey and ShiftKey attributes to ridiculously high numbers that would evaluate to truth-y, but wouldn't be
== True
, which was the check I tend to use.A third issue is that since I now use the command key as a modifier, command clicking inside a cell in the spreadsheet would toggle it to unselected. This was annoying, and it doesn't look like it's actually a useful feature at all, so I just made it so we don't pass the control modifier to the
cellActivated
function, and instead passFalse
for thetoggle
value.@remram44 @doutriaux1 If you can test this on Ubuntu, that'd be great… my mac is converting the control + left click into a right click before it gets through to my VM, so I'm not certain if it's set up correctly there.